Chromium changeLogs from ]164089 to 164256]
nkang@chromium.org
2012-10-25T17:00:14.534073Z
Moved Main class to a new file called run_install_tests.py and modified it by adding the ability to filter unittests. This will allow users to run individual unittests, a set of tests, or the entire suite.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11234068
bradchen@google.com
2012-10-25T17:02:29.164894Z
Disable more tests in Dr Memory (crbug.com/157682)
BUG=157682
TBR=rnk
Review URL: https://codereview.chromium.org/11262035
xhwang@chromium.org
2012-10-25T17:03:47.496525Z
Fake clear key CDM audio decoder.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11242005
stevenjb@chromium.org
2012-10-25T17:08:28.507565Z
Indicate tab recording state in tab strip
Adds MediaStreamCaptureIndicator::IsProcessCapturing() to retrieve recording state.
BUG=156130
Review URL: https://codereview.chromium.org/11236052
sadrul@chromium.org
2012-10-25T17:19:42.203002Z
ash: Remove some inconsistency from two-finger window moving.
Allow two-finger window moving only if both fingers are on the same edge of the window.
BUG=151153
Review URL: https://codereview.chromium.org/11269031
gman@chromium.org
2012-10-25T17:21:38.189160Z
Revert "Revert 164047 - Make GL calls go through subclassable class."
This reverts commit 25afcfe213ffd88f8e9370d4ff1ee23ecf9ae16c.
BUG=155557
TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/11264041
sergeyu@chromium.org
2012-10-25T17:29:38.693932Z
Remove old unused OAuth client id from remoting_me2me_host.cc
Review URL: https://chromiumcodereview.appspot.com/11269024
mseaborn@chromium.org
2012-10-25T17:32:05.470996Z
NaCl: Remove the nacl_standalone==1 case from plugin.gyp
We no longer support building the NaCl PPAPI proxy plugin as a
standalone plugin that can be loaded via --register-pepper-plugins.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2730
TEST=trybots
Review URL: https://codereview.chromium.org/11269026
markus@chromium.org
2012-10-25T17:35:22.237331Z
Rolling DEPS for legacy seccom sandbox in order to work around a bogus warning in gcc 4.7
BUG=n/a
TEST=n/a
Review URL: https://chromiumcodereview.appspot.com/11273032
chrome-admin@google.com
2012-10-25T17:36:35.181089Z
Update .DEPS.git
mihaip@chromium.org
2012-10-25T17:37:42.571012Z
Remove beginInstallWithManifest2 alias.
The Chrome Web Store should always be calling beginInstallWithManifest3.
BUG=156498
R=asargent@chromium.org
Review URL: https://codereview.chromium.org/11205005
zvorygin@chromium.org
2012-10-25T17:38:19.721561Z
[FileBrowser] Disabled nested folder creation command, while creating new folder.
BUG=151643
TEST=Manual. See issue description.
Review URL: https://chromiumcodereview.appspot.com/11264036
phajdan.jr@chromium.org
2012-10-25T17:39:05.216172Z
Remove more nonessential directories in export_tarball,
reducing the tarball size by ~ 50 MB (220 -> 170 MB).
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11226066
reveman@google.com
2012-10-25T17:48:07.714443Z
cc: Rename CanvasLayerUpdater to ContentLayerUpdater.
sed -e '
s/CanvasLayerUpdater/ContentLayerUpdater/g
s/canvas_layer_updater/content_layer_updater/g
'
BUG=
TEST=cc_unittests
Review URL: https://codereview.chromium.org/11271022
mihaip@chromium.org
2012-10-25T17:48:27.974789Z
Update link to sample in the <webview> documentation.
TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/11269052
mseaborn@chromium.org
2012-10-25T17:50:41.444170Z
NaCl: Remove "#ifdef NACL_STANDALONE" code paths
We no longer support building the NaCl PPAPI plugin as a standalone
plugin that can be loaded via --register-pepper-plugins: the
standalone NaCl build no longer tests that.
We simplify the code under the assumption that NACL_STANDALONE is
never defined. This removes the plugin's support for launching the
standalone sel_ldr.
Remove NaClPluginGetSandboxISA(), which was only used in a test case
that has been removed.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2730
TEST=trybots
Review URL: https://codereview.chromium.org/11274025
zhaoqin@google.com
2012-10-25T17:55:09.818289Z
exclude more tests from browser_tests with Dr.Memory
TBR=bruening@chromium.org
Review URL: https://codereview.chromium.org/11274048
michaelbai@chromium.org
2012-10-25T17:58:07.641523Z
Roll third_party/findbugs to 163586 for Android
BUG=
Review URL: https://chromiumcodereview.appspot.com/11271012
nkang@chromium.org
2012-10-25T18:06:11.258344Z
Revert 164090 - Moved Main class to a new file called run_install_tests.py and modified it by adding the ability to filter unittests. This will allow users to run individual unittests, a set of tests, or the entire suite.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11234068
TBR=nkang@chromium.org
Review URL: https://codereview.chromium.org/11262040
gbillock@chromium.org
2012-10-25T18:08:39.911577Z
Get rid of unused SerializedScriptValue references.
R=michaeln@chromium.org,jam@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11228062
dharcourt@chromium.org
2012-10-25T18:12:15.269380Z
Cleanup in preparation for adding calculator controller tests.
To distinguish between cleanup and functionality change, the cleanup
involved with adding controller tests for the calculator app has been
isolated to this change list. Another change list will contain
functionality changes. This change list contains only these 3 changes:
1) tests.html was split into automatic.html and manual.html. This allows
automatic tests to run faster without the manual page scripts (now
manual.js) and style (now manual.css). It also simplifies the manual
test page and allows manual tests to be run by simple loading that page.
2) manual.html's style was simplified to make that page more readable.
3) utilities.js's methods were reordered from high-level to low-level to
make that file more readable and more easily refactored.
BUG=156695
Review URL: https://chromiumcodereview.appspot.com/11276004
viettrungluu@chromium.org
2012-10-25T18:12:57.684679Z
Mac NPAPI Flash: don't copy the additional plugin.vch file.
Flash 11.5 will put it inside the bundle, as far as I can tell.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11266039
bradchen@google.com
2012-10-25T18:24:20.043517Z
Move gtest_excludes to proper exclude files.
BUG=157682
TBR=rnk
Review URL: https://codereview.chromium.org/11271028
jhorwich@chromium.org
2012-10-25T18:27:32.174770Z
Revert 164108 - Roll third_party/findbugs to 163586 for Android
(I believe this breaks check_deps2git)
BUG=
Review URL: https://chromiumcodereview.appspot.com/11271012
TBR=michaelbai@chromium.org
Review URL: https://codereview.chromium.org/11267048
aberent@chromium.org
2012-10-25T18:43:25.759509Z
Upstream remaining differences in android/build python files
Re-enable unit tests in single_test_runner (these are no longer flaky)
Allow stack trace, since we now admit we are doing an Android version of Chrome
Add keep_test_server_ports option to instrumentation tests.
BUG=136980
Review URL: https://chromiumcodereview.appspot.com/11262034
zhaoqin@google.com
2012-10-25T18:43:55.833419Z
excludes more tests from browser_tests with Dr.Memory
TBR=bruening@chromium.org
Review URL: https://codereview.chromium.org/11271029
stevenjb@chromium.org
2012-10-25T18:43:56.734830Z
Replace shadow assets
BUG=154959
R=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11185068
tfarina@chromium.org
2012-10-25T18:44:52.457758Z
content/browser: Move more files into the content namespace.
Fixed most of the files found with the following command line:
$ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm}
R=jam@chromium.org
Review URL: https://codereview.chromium.org/11274038
sail@chromium.org
2012-10-25T18:54:36.693260Z
Revert 164120 - content/browser: Move more files into the content namespace.
Fixed most of the files found with the following command line:
$ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm}
R=jam@chromium.org
Review URL: https://codereview.chromium.org/11274038
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/11273049
beaudoin@chromium.org
2012-10-25T18:54:47.406816Z
When bookmarking the NTP show the bookmark bubble attached to the wrench menu.
BUG=156704
Review URL: https://chromiumcodereview.appspot.com/11233053
gbillock@chromium.org
2012-10-25T18:55:03.338187Z
Add flag to enable web content to invoke web intents.
R=jhawkins@chromium.org,darin@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11187058
jamesr@chromium.org
2012-10-25T18:55:18.624261Z
Throttle prepaints to avoid colliding with post-load work
On the page cyclers (especially intl1) the prepaint logic in the compositor
interferes with the subsequent page's load time when --force-compositing-mode
is active. This is because the prepaint schedules a commit immediately
after finishing a prepaint-eligible paint. On the page cyclers, this means that
we frequently do a second commit just after starting the load on the next page
in the set since the new page's URL is set just after the onload event.
This patch tweaks the prepaint to happen only after we perform an updateLayers()
that's prepaint eligible and then go 100ms (number picked somewhat arbitrarily)
without receiving another setNeedsCommit(). The goal is to only prepaint if
the compositor scene is roughly steady - if we're still receiving invalidations
on the main content then it's less likely that prepainting will be useful.
On pages in the wild that load quickly, the first prepaint after first paint is
likely to collide with onload and shortly-after-onload logic. Delaying until we
reach a steady state shouldn't slow down static pages but will help avoid
contention and wasted work on pages that modify the page on or shortly after
onload.
BUG=152355
Review URL: https://chromiumcodereview.appspot.com/11273029
tonyg@chromium.org
2012-10-25T18:59:05.996309Z
[chrome-remote-control] Fix scrolling on docs.
The "r" variable conflicted with window.r on docs which caused an error to be
thrown. Declaring them locallly fixes this.
Example error:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/18424/steps/scrolling_benchmark/logs/stdio
BUG=None
TEST=Manual on Linux
Review URL: https://codereview.chromium.org/11276031
apatrick@chromium.org
2012-10-25T19:06:01.651935Z
Roll ANGLE DEPS back 1289:1270
To verify it works prior to rolling back m23.
Review URL: https://codereview.chromium.org/11263029
milanb@chromium.org
2012-10-25T19:06:26.489373Z
Add initialization for ios audio-video framework.
The default initialization on ios blocks audio input
when audio output is active. This enables duplex mode.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11276024
chrome-admin@google.com
2012-10-25T19:06:32.473777Z
Update .DEPS.git
epenner@chromium.org
2012-10-25T19:06:40.881386Z
One good thing (the only good thing?) about the recent texture
manager bug, is that it clarified where in-use-on-impl textures need
to be protected (in the texture manager - the lack of which was the
bug).
The deleteTextureAfterCommit mechanism protects the 'front-buffer'
when double-buffering updates, but it was never quite functional
since it doesn't protect 'front-buffer' textures for layers which
are deleted entirely while they still exist in the impl-tree.
Since the texture manager takes care of this, we can remove this
redundant protection code and just discard the texture backing when
a buffered update is required.
Once textures live primarily on the impl-thread and can be removed
from the impl-tree, the notion of 'in-use' can become much more
accurate, and the number of textures which are not safe to be evicted
or recycled will be greatly reduced.
Review URL: https://chromiumcodereview.appspot.com/11028132
sadrul@chromium.org
2012-10-25T19:07:27.809368Z
views: Make sure a gesture event is not processed more than once.
If a gesture event has already been processed, then the event should not
reach the menu-controller.
BUG=150759
Review URL: https://codereview.chromium.org/11276029
agayev@chromium.org
2012-10-25T19:09:18.242947Z
Cache backend for devices with flash storage
Fixed tests.
BUG=157187
TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164064
Review URL: https://chromiumcodereview.appspot.com/11269008
mihaip@chromium.org
2012-10-25T19:13:33.950783Z
Disable pushState and the rest of the history API in packaged apps via runtime-enabled features
Chrome Apps do not support the history API (or navigation in general). Since
pushState is generally feature detected, it's cleanest to disable it
per-document, so that applications can have the appropriate fallback behavior
(other history APIs are re-mapped to throw exceptions, since history.back() and
the link are not feature detected).
Depends on http://webkit.org/b/99780.
BUG=146076
R=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11196055
bartfab@chromium.org
2012-10-25T19:13:45.971770Z
Add Chrome OS-specific controlled setting indicators
This completes the addition of controlled setting indicators to the
Chrome settings UI.
BUG=104955
Review URL: https://chromiumcodereview.appspot.com/11276006
ncbray@chromium.org
2012-10-25T19:14:07.630973Z
Remove more redundant PPAPI interface tests from NaCl's SCons build.
BUG= http://code.google.com/p/chromium/issues/detail?id=154400
Review URL: https://chromiumcodereview.appspot.com/11276017
shishir@chromium.org
2012-10-25T19:19:54.022228Z
Enabling Speculative Resource Prefetching 1% in dev/canary.
BUG=149743
Review URL: https://chromiumcodereview.appspot.com/11262023
sgurun@chromium.org
2012-10-25T19:26:03.363704Z
make the scripts happy
add a few trivial default/statics to make build scripts happy.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11264039
achuith@chromium.org
2012-10-25T19:26:16.028534Z
Fix bugs in ConvertDocumentEntryToDriveEntryProto
* document extension and is_directory were not set.
* add unit tests.
BUG=137374
TEST=unit test.
Review URL: https://codereview.chromium.org/11267037
sky@chromium.org
2012-10-25T19:29:05.041768Z
Makes toggling the brightness and volumn not force the launcher to
show. The arrow needs to be updated, but that can be done separately.
BUG=157899
TEST=none
R=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275045
rlp@chromium.org
2012-10-25T19:29:22.148082Z
Pulling custom dictionary out of spellcheck_profile as prep to combine profile and host.
BUG=154921
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11175041
kkania@chromium.org
2012-10-25T19:31:20.098769Z
Revert 164109 - Revert 164090 - Moved Main class to a new file called run_install_tests.py and modified it by adding the ability to filter unittests. This will allow users to run individual unittests, a set of tests, or the entire suite.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11234068
TBR=nkang@chromium.org
Review URL: https://codereview.chromium.org/11262040
TBR=nkang@chromium.org
Review URL: https://codereview.chromium.org/11272034
Patch from Navdeep Kang <nkang@chromium.org>.
sergeyu@chromium.org
2012-10-25T19:37:11.999822Z
Fix remoting me2me host to properly process --host-config option.
Me2Me host was broken in crrev.com/163915 - the code that parses
--host-config parameter was removed by mistake. Adding it back.
Review URL: https://codereview.chromium.org/11260034
oshima@chromium.org
2012-10-25T19:43:11.020442Z
Handle OnBoundsChanged for fullscreen RWHV because it dosen't have WebContentsViewAura that calls SetSize
BUG=13073
TEST=manual: see bug for repro step.
Review URL: https://chromiumcodereview.appspot.com/11270022
mkosiba@chromium.org
2012-10-25T19:45:17.456537Z
Handle a null RenderViewHost in the InterceptNavigationResourceThrottle.
If many tabs are opened and closed in a rapid succession it is possible
for the UI thread callback to run after the RVH that is associated with
the URLRequest has been deleted.
TBR=joi@chromium.org
BUG=None
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/11270037
mukai@chromium.org
2012-10-25T19:48:58.184102Z
Allow multi-lined display names in chrome://settings/display.
Previously the display name is put at the middle of the rectangle just by specifying lineHeight, but this approach doesn't work well if the display name needs multiple lines.
Such long name has been hypothetical so far, but we will use "Internal Display" for internally connected ones, which may consume multiple lines in some display configuration.
BUG=157672
Review URL: https://chromiumcodereview.appspot.com/11267024
joi@chromium.org
2012-10-25T19:54:59.623006Z
Add maruel@ and joi@ as per-file OWNERS for PRESUBMIT.py
BUG=none
Review URL: https://codereview.chromium.org/11260011
kuan@chromium.org
2012-10-25T19:55:03.915893Z
implement bookmark bar for instant extended api
in ntp mode:
- regardless of "Show bookmark bar" pref setting, if bottom panel of content view (i.e. "Most visited" thumbnails) show, bmb is always visible and detached, floating on top of content view below the most-visited thumbnails.
- height constraint of content view is handled both in native code and javascript.
- javascript makes sure that bottom panel always leaves enough bottom padding for bmb when it's showing.
- bmb is made to appear as if it's part of content view:
* there's no colored bar or background.
* each button appears as see-through to the background of content view, without subpixel rendering for its text rendering.
* when hovering over a button, its background and borders are painted.
- bmb is set to use layer, and stacked on top of content view after ntp views are created, in SearchViewController::StackAtTop, and in SearchNTPContainerView::Layout after the bmb is laid out.
in non-ntp mode, bmb behaves like regular chrome, except:
- it doesn't show in suggestions mode
- its separator doesn't show except in default mode
BUG=142790
TEST=verify per bug rpt
Review URL: https://chromiumcodereview.appspot.com/11175025
rohitrao@chromium.org
2012-10-25T19:55:15.478722Z
Adds GoogleURLTracker strings to the iOS grit whitelist.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11276005
jhorwich@chromium.org
2012-10-25T19:57:28.934616Z
Revert 164142 - Pulling custom dictionary out of spellcheck_profile as prep to combine profile and host.
(check_perms flagged the added files)
BUG=154921
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11175041
TBR=rlp@chromium.org
Review URL: https://codereview.chromium.org/11269057
weili@chromium.org
2012-10-25T20:02:53.359258Z
Make Action Box UI disabled by default.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11230067
ccameron@chromium.org
2012-10-25T20:03:08.979609Z
Report memory usage statistics from the renderer.
Add functions to PrioritizedTextureManager to report the amount of visible and nearly-visible memory, based on the requested set of textures to draw (note that this is a superset of the backings that will be visible and nearly-visible). Add a unittest for this functionality.
Add infrastructure in the Proxy to send this data to the renderer. From here the data will go to the WebGraphicsContext3D, then the GPU command buffer, and finally the GPU memory manager.
BUG=134750
Review URL: https://chromiumcodereview.appspot.com/11230064
mseaborn@chromium.org
2012-10-25T20:05:25.062589Z
NaCl: Update revision in DEPS, r10072 -> r10094
This pulls in the following Native Client changes:
r10073: (dschuff) Swap toolchain directories for archived frontend test
r10074: (jfb) Change BKPT and UDF encodings on ARM.
r10075: (bradnelson) Adding a directory storage adapter.
r10076: (jfb) Revert "Change BKPT and UDF encodings on ARM."
r10077: (eliben) Fix typo in usage string to point to the correct script - in the ARM toolchain
r10078: (bradnelson) Adding run_build_tests target to scons.
r10079: (dschuff) Remove global git config from mergebot script and fix git remote setup
r10080: (dschuff) Update pnacl DEPS to merge to 166481
r10081: (dschuff) LLVM merge-bot: move LLVM repo cleanup to before gclient invocation
r10082: (dschuff) Make merge bot script use verbose mode of pnacl build.sh script
r10083: (dschuff) Mergebot: Reduce number of SPEC tests and fix ARM spec invocation
r10084: (bradnelson) Adding in new toolchain build for 4 modules.
r10085: (bradnelson) Adding a build command memoizer.
r10086: (kschimpf) Fix table simd_load_store_l0 (NEON) for ARM.
r10087: (dschuff) Roll pnacl TOOL_REVISIONS to 10082
r10088: (mseaborn) Add the ability to run Scons tests via SSH, e.g. for testing ARM
r10089: (mseaborn) Gyp build: Enable -Wundef warnings for untrusted code
r10090: (bradnelson) Next-gen toolchain build for newlib arm.
r10091: (jvoung) Update perf_expectations for llc and ld size w/ --gc-sections applied.
r10092: (bsy) logging statement output string typos ("avi" instead of "abi").
r10093: (mseaborn) Scons: Declare some dependencies required for using run_test_via_ssh.py
r10094: (jfb) Change pointer to new LLVM version with BKPT and UDF fixes.
BUG=none
TEST=nacl_integration
Review URL: https://codereview.chromium.org/11262027
chrome-admin@google.com
2012-10-25T20:06:35.949111Z
Update .DEPS.git
sadrul@chromium.org
2012-10-25T20:07:10.442829Z
touch: Make sure the touch-events created from an acked WebTouchEvents are in correct state.
This fix is specifically for cases where a second-finger press would end up
generating an erroneous press-event for the first finger as well as for the
second finger.
BUG=110231
Review URL: https://codereview.chromium.org/11266040
yusukes@chromium.org
2012-10-25T20:08:04.658838Z
Update comments in BrowserView::PreHandleKeyboardEvent().
- Ctrl+t is now an Ash accelerator on Chrome OS.
- F4 is also Ash's.
- Ctrl+w is still Chrome's reserved accelerator and is unlikely changed.
- Ctrl+f is still Chrome's unreserved accelerator and is unlikely changed.
BUG=None
TEST=None (no code change)
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11269025
kaznacheev@chromium.org
2012-10-25T20:18:09.158980Z
Fix folder icon in the Files app thumbnail view.
BUG=136531
Review URL: https://chromiumcodereview.appspot.com/11275043
kbr@chromium.org
2012-10-25T20:18:21.431987Z
Added suppression for Google-private data directory only present in official Chrome checkouts.
BUG=none
TEST=ran checklicenses locally
TBR=phajdan.jr@chromium.org,thestig@chromium.org
Review URL: https://codereview.chromium.org/11270045
tomfinegan@chromium.org
2012-10-25T20:18:25.923091Z
Add FFmpeg audio decoder for the clear key CDM.
BUG=141780
TEST=
Review URL: https://chromiumcodereview.appspot.com/11260007
csharp@chromium.org
2012-10-25T20:26:10.563081Z
Update Linux's browser_tests.isolate to get more tests to pass.
TBR=maruel@chromium.org
NOTRY=True
BUG=
Review URL: https://chromiumcodereview.appspot.com/11263051
pkasting@chromium.org
2012-10-25T20:36:05.525540Z
Fix places where "request" is misspelled "requst". Surprisingly, there are several.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11268002
scheib@chromium.org
2012-10-25T20:36:16.736050Z
Roll WebKit 132486 -> 132490
TBR=pfeldman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11272033
bradchen@google.com
2012-10-25T20:36:37.595110Z
Generalize suppression for DomStorageContext::CreateSessionNamespace
BUG=157885
TBR=jam
Review URL: https://codereview.chromium.org/11270046
chrome-admin@google.com
2012-10-25T20:40:13.416173Z
Update .DEPS.git
munjal@chromium.org
2012-10-25T20:54:41.434087Z
chrome.experimental.identity.launchWebAuthFlow doesn't catch JS redirects
The problem is that WebAuthFlow doesn't get any of the notifications
it listens to when a URL is changed by Javascript.
After trying a few things, looks like WebContentsObserver::ProvisionalChangeToMainFrameUrl
is called when window.location is changed in JS.
Since now WebAuthFlow is a WebContentsObserver, move to using observer callbacks for most
things and stop listening to NOTIFICATION_LOAD_START, NOTIFICATION_LOAD_STOP, NOTIFICATOIN_WEB_CONTENTS_DESTROYED.
It is preferable to use observer anyway since some notifications don't work great. For example, load_details is
always NULL when NOTIFICATION_LOAD_START is called.
Note that we cannot still stop being a NotificationsObserver since in some redirect patterns only the
NOTIFICATION_RESOURCE_RECEIVED_REDIRECT is called. But I reduced the use of notifications to a minimum now.
BUG=148607
TEST=Apart from unit tests, tested with Google, Facebook and the test auth app attached in the bug extensively
in interactive and non-interactive mode, in sign-in and not signed-in state, in pre-approved and not pre-approved state.
Review URL: https://chromiumcodereview.appspot.com/11184055
aa@chromium.org
2012-10-25T20:56:39.035813Z
Fix "Get more extensions" link in about:extensions.
BUG=157944
TBR=jhawkins
Review URL: https://codereview.chromium.org/11276036
asvitkine@chromium.org
2012-10-25T20:57:48.363712Z
[Mac] Fix dictionary popup in text areas.
In the case of selected text in a text area, |selection_text_| actually
stores the whole text in the text area (or at least a large range of it),
and the subset that's selected is specified via |selection_text_offset_|
and |selection_range_|. This change fixes the logic when comparing the
text to actually compare that substring instead of the complete range.
This was broken by http://crrev.com/158988.
Note: It mirrors the substring logic done by RenderWidgetHostViewMac::SelectionChanged().
BUG=154608
TEST=see bug instructions
Review URL: https://codereview.chromium.org/11269053
rdsmith@chromium.org
2012-10-25T20:59:24.133407Z
Switch CHECKS related to asserting correct state for download files in DownloadItem back to Dchecks.
R=benjhayden@chromium.org
BUG=123998
Review URL: https://chromiumcodereview.appspot.com/11274050
chrisha@chromium.org
2012-10-25T20:59:36.790710Z
Allow lastchange.py to be used for arbitrary repositories.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11266037
achuith@chromium.org
2012-10-25T21:07:23.195172Z
Introduce DriveEntryProtoMap.
* DriveResourceMetadata::RefreshDirectory now takes a DriveEntryProtoMap instead of a ResourceMap.
* Introduce a helper method DriveResourceMetadata::FromProto that creates a DriveEntry from a proto.
* Change return type of ApplyFeeds and FeedToEntryProtoMap to void. These always returned DRIVE_FILE_OK.
* Rename FeedToResourceMap to FeedToEntryProtoMap, which takes a DriveEntryProtoMap* instead of a ResourceMap*.
* Rename ApplyFeedFromResourceMap to ApplyEntryProtoMap, which takes a DriveEntryProtoMap instead of a ResourceMap.
* Proto dropped the deleted flag on conversion to DriveEntry.
BUG=137374
TEST=unit tests.
Review URL: https://codereview.chromium.org/11266026
jbauman@chromium.org
2012-10-25T21:08:25.571338Z
Don't crash when destoying transfer buffer that isn't mapped.
It's possible GetTransferBuffer was never called, or that it failed due to a GPU process crash, so don't crash when the transfer buffer isn't in the cache.
BUG=https://code.google.com/p/chrome-os-partner/issues/detail?id=14476
Review URL: https://chromiumcodereview.appspot.com/11270036
nkang@chromium.org
2012-10-25T21:11:44.254320Z
Modified InstallTest.Install so the user can specify the location of the master preferences file. Also, updated the Main class so it can run both user and system level installations in the same run.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11262045
reveman@google.com
2012-10-25T21:22:55.212797Z
cc: Rename TextureUpdate to ResourceUpdate.
sed -e '
s/TextureUpdateQueue/ResourceUpdateQueue/g
s/texture_update_queue/resource_update_queue/g
s/TextureUpdateController/ResourceUpdateController/g
s/texture_update_controller/resource_update_controller/g
'
BUG=
TEST=cc_unittests
Review URL: https://codereview.chromium.org/11270047
MHX348@motorola.com
2012-10-25T21:27:52.237401Z
Arrow key navigation broken in ActionBox menu.
!= has higher precedence than ternary operator.
Patch from Joe Thomas <mhx348@motorola.com>.
BUG=157930
TEST=As mentioned in the bug report.
Review URL: https://chromiumcodereview.appspot.com/11269055
youngki@chromium.org
2012-10-25T21:31:20.278229Z
Made BluetoothAdapterFactory return BluetoothAdapterWin on Windows platform. Currently BluetoothAdapterWin is a class with empty implementation.
Also I renamed bluetooth_apitest_chromeos.cc as bluetooth_apitest.cc so that this test runs on all platforms. The test is already platform-independent.
I think it's safe to integrate BluetoothAdapterWin into BluetoothAdapterFactory as long as we run bluetooth_apitest.cc on Windows platform. Also BluetoothAdapterWin is basically a no-op class anyways.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11267002
zmo@chromium.org
2012-10-25T21:37:46.368528Z
Fix lexical driver version comparison issue in GPU blacklisting.
We made the wrong assumption that AMD linux drivers only use the format of major.minor, where minor version uses lexical ordering. However, sometimes they may have more details than just major/minor version.
Also, no longer use Version in base/ because it does not accept version number with leading 0s. Implement our own version comparison op.
BUG=157614,135341,157429
TEST=content_unittests, manual on AMD Linux machine
Review URL: https://codereview.chromium.org/11263022
jennyz@chromium.org
2012-10-25T21:38:17.520144Z
Add FORMAT_REMAINING_LONG in TimeFormat class to support formatting remaining time in long minute format.
BUG=157169
TBR=sky
Review URL: https://codereview.chromium.org/11272035
ananta@chromium.org
2012-10-25T21:42:48.340744Z
Prevent the BrowserWindow from being closed when the extension tab is closed in Windows 8 metro mode
as we reuse an existing BrowserWindow to host the extension tab.
BUG=157487
R=mihaip
Review URL: https://codereview.chromium.org/11263055
scheib@chromium.org
2012-10-25T21:47:23.710346Z
Roll WebKit 132490 -> 132500
TBR=pfeldman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11272038
ncbray@google.com
2012-10-25T21:48:30.712441Z
Reduce log spew in nacl_integration.
BUG= none
Review URL: https://codereview.chromium.org/11301002
chrome-admin@google.com
2012-10-25T21:48:32.721252Z
Update .DEPS.git
bradchen@google.com
2012-10-25T22:00:38.870215Z
2nd try; put tests in proper gtest_exclude files for DrMemory.
BUG=157682
TBR=zhaoqin
Review URL: https://codereview.chromium.org/11264043
kaznacheev@chromium.org
2012-10-25T22:25:26.830537Z
Make the title of Chrome OS Audio Player empty
BUG=151847
Review URL: https://chromiumcodereview.appspot.com/11269043
bartfab@chromium.org
2012-10-25T22:36:12.364937Z
Remove the managed banner from the Chrome settings UI
This banner has been obsoleted by the controlled setting indicators.
BUG=104955
Review URL: https://chromiumcodereview.appspot.com/11272026
scheib@chromium.org
2012-10-25T22:45:48.923451Z
Roll WebKit 132500 -> 132510
TBR=pfeldman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11263049
piman@chromium.org
2012-10-25T22:47:48.980870Z
Fix output targets to avoid rebuilds.
generate_gl_bindings was specifying the wrong outputs in gyp, making it always dirty.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11274051
fsamuel@chromium.org
2012-10-25T22:48:09.100011Z
Don't allow the browser plugin to be instantiated if the app doesn't have the "webview" permission
BUG=157711
Test=WebViewTest.*, BrowserPluginHostTest.*, BrowserPluginTest.*
Review URL: https://codereview.chromium.org/11274035
chrome-admin@google.com
2012-10-25T22:48:36.179567Z
Update .DEPS.git
sail@chromium.org
2012-10-25T22:52:19.242437Z
Disable PerformanceMonitorBrowserTest.DisableAndEnableExtensionEvent
Test is falky. See bug.
BUG=157980
TBR=aa@chromium.org
Review URL: https://codereview.chromium.org/11271034
fsamuel@chromium.org
2012-10-25T22:54:34.959545Z
Browser Plugin: Remove unused ViewMsg_Navigate_Params
BUG=none
Review URL: https://codereview.chromium.org/11265034
robertshield@chromium.org
2012-10-25T22:55:39.286745Z
Fix window resizing and repositioning in GCAPI.
BUG=154707
TEST=Launch Google Chrome first run experience using LaunchGoogleChromeWithDimensions export on gcapi.dll, notice it open in backgroun.
Review URL: https://chromiumcodereview.appspot.com/11272031
fsamuel@chromium.org
2012-10-25T22:55:45.653097Z
Browser Plugin: Guest renderers should have the same sandbox policy as other renderers.
BUG=157910
TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/11266043
sail@chromium.org
2012-10-25T23:08:40.958570Z
Disable ThreadedCompositorTest.ThreadedCompositor
Test is failing on Linux. See bug.
BUG=157985
Review URL: https://codereview.chromium.org/11265039
hclam@chromium.org
2012-10-25T23:13:25.364938Z
Prevent DCHECK in MediaStreamDependencyFactory::CreatePeerConnectionFactory
|audio_device_| should be released if PeerConnectionFactory fails to be
created.
BUG=157786
Review URL: https://chromiumcodereview.appspot.com/11276020
jianli@chromium.org
2012-10-25T23:28:16.090476Z
Fix the problem that panel on Windows is shown without round corners and shadow.
The fix is to switch between the overlapped style and popup style.
BUG=none
TEST=existing and new tests
Review URL: https://chromiumcodereview.appspot.com/11228058
skuhne@google.com
2012-10-25T23:28:19.871261Z
Replacing 200% icons for window_position_right_.._restore.png
BUG=155200
TEST=visual inspection
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/11271036
boliu@chromium.org
2012-10-25T23:32:28.096685Z
Implement AwContentBrowserClient and AwBrowserContext
Some other classes that are added in this patch:
AwBrowserMainParts, AwQuotaPermissionClient,
AwUrlRequestContext[Getter], AwResourceContext.
There is enough implementation for these classes so that
existing instrumentation tests still pass. A lot of TODOs
are added for future work beyond this patch.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11184051
jam@chromium.org
2012-10-25T23:40:05.506123Z
Initial change to make some browser_tests pass on win/linux aura builds.
Review URL: https://codereview.chromium.org/11196047
shadi@chromium.org
2012-10-25T23:40:08.511284Z
Fix EME browser tests endOfStream() on media source.
Using the current version of media source API, we need to call endOfStream() after a seek event.
Enabling FrameChangeVideo tests because this might resolve flakiness.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11265030
scheib@chromium.org
2012-10-26T00:01:17.256493Z
Roll WebKit 132500 -> 132520
TBR=pfeldman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11265038
tfarina@chromium.org
2012-10-26T00:01:51.633655Z
cc: Remove wtf includes from delay_based_time_source.cc
cmath seems to be enough for our needs here.
BUG=154451
R=enne@chromium.org,jamesr@chromium.org
Review URL: https://codereview.chromium.org/11265018
chrome-admin@google.com
2012-10-26T00:03:36.631335Z
Update .DEPS.git
jsbell@chromium.org
2012-10-26T00:06:51.470193Z
IndexedDB: Ensure pending callbacks are fired before dispatcher is torn down
Worker termination was marking the dispatcher as "deleted" before pending
callbacks were destructed, and some of those pending callbacks were trying
to use the dispatcher. Swap the order by explicitly clearing out callback
maps rather than relying on implicit destruction.
R=dgrogan@chromium.org,michaeln@chromium.org
BUG=153652
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163972
Review URL: https://chromiumcodereview.appspot.com/11287002
sail@chromium.org
2012-10-26T00:08:50.403205Z
Disable HttpPipeliningCompatibilityClientTest.CanaryFailure on ChromeOS
See bug for more info.
BUG=147903
Review URL: https://codereview.chromium.org/11260050
cduvall@chromium.org
2012-10-26T00:29:24.925292Z
Extensions Docs Server: Show parameters of functions that are properties of an object
The docs server was not showing the parameters of a function that was a property
of an object. This is now fixed.
BUG=156673
Review URL: https://codereview.chromium.org/11195058
benwells@chromium.org
2012-10-26T00:45:18.750384Z
Replace Settings App placeholder icons with designer icons.
BUG=130210
TEST=`chrome.exe --enable-settings-app --show-app-list` should show new icon (cog with 6 spokes, not 8)
Review URL: https://codereview.chromium.org/11267029
cduvall@chromium.org
2012-10-26T00:45:26.648070Z
Extensions Docs Server: Fix handling of nodocs in server2
Some nodocs were being left in the documentation by server2.
BUG=154387
Review URL: https://codereview.chromium.org/11195055
junov@chromium.org
2012-10-26T00:57:38.345882Z
Prevent TextureLayer from triggering commits and texture acquisitions when
the layer does not draw its contents.
BUG=138448
TEST=cc_unittests TextureLayerTest.syncImplWhenDrawing
Review URL: https://chromiumcodereview.appspot.com/11226061
estade@chromium.org
2012-10-26T00:57:51.699661Z
remove ConstrainedWindowViews dependency on BrowserWindow.
also make the fallback centering.
BUG=156694
Review URL: https://chromiumcodereview.appspot.com/11269029
justinlin@chromium.org
2012-10-26T00:58:16.663563Z
Implement chrome extension tab capture API as specified here:
http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture
Also, make tab capture media stream requests verify that the request came from extension API.
BUG=153388
Review URL: https://chromiumcodereview.appspot.com/11273033
scheib@chromium.org
2012-10-26T01:00:59.051642Z
Revert 164218 - Roll WebKit 132500 -> 132520
TBR=pfeldman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11265038
TBR=scheib@chromium.org
Review URL: https://codereview.chromium.org/11266063
sail@chromium.org
2012-10-26T01:02:13.591716Z
Mac: Suppress removable storage notifications for DMGs
This CL suppresses attached and detached notifications for DMGs.
BUG=153813
TEST=Mounted several DMGs. Verified that notifications were not posted. Attached a USB drive. Verified that notifications were posted.
Review URL: https://chromiumcodereview.appspot.com/11188049
kuan@chromium.org
2012-10-26T01:02:35.418914Z
themes for alternate ntp: fix messed up ntp theme background image w/ devtools
i was using browser view size to determine which part of ntp theme background image to draw for what view; this doesn't work when devtools is open.
fix to use size from top of tab to bottom of content view.
BUG=157012
TEST=verify per bug rpt
Review URL: https://chromiumcodereview.appspot.com/11273007
anandc@chromium.org
2012-10-26T01:02:47.395599Z
Rebase perf_av test expectations for Windows build, post CL 161384 and CL 163213.
Related bugs: 157964,157967 and 157974.
BUG=None
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11272046
chrome-admin@google.com
2012-10-26T01:04:17.207454Z
Update .DEPS.git
dalecurtis@google.com
2012-10-26T01:06:19.619494Z
Handle audio device changes on Windows.
Uses the new AudioDeviceListener framework to notify of device
changes. Handles only default device changes at the moment,
e.g., not manually changing the sample rate, etc on a current
default device.
This all works well enough that I can connect / disconnect remote
desktop sessions with and without audio and everything continues
to play seamlessly and in sync!
BUG=153056
TEST=Unplug... Plug... Unplug! Plug!
Review URL: https://codereview.chromium.org/11233023
cduvall@chromium.org
2012-10-26T01:23:36.536014Z
Extensions Docs Server: Gracefully handle bad Github data
This will prevent errors like these:
Traceback (most recent call last):
File "/base/data/home/apps/s~chrome-apps-doc/2-0-7.362231368946707729/appengine_main.py", line 18, in <module>
from handler import Handler
File "/base/data/home/apps/s~chrome-apps-doc/2-0-7.362231368946707729/handler.py", line 53, in <module>
AppEngineBlobstore())
File "/base/data/home/apps/s~chrome-apps-doc/2-0-7.362231368946707729/github_file_system.py", line 45, in __init__
self._GetZip(self.Stat(ZIP_KEY).version)
File "/base/data/home/apps/s~chrome-apps-doc/2-0-7.362231368946707729/github_file_system.py", line 91, in Stat
self._fetcher.Fetch('commits/HEAD').content)['commit']['tree']['sha']
KeyError: 'commit'
Review URL: https://codereview.chromium.org/11189153
shadi@chromium.org
2012-10-26T01:31:43.034280Z
Add new media files for encrypted browser tests.
BUG=None
Review URL: https://codereview.chromium.org/11272048
justinlin@chromium.org
2012-10-26T01:35:16.692867Z
Turn tab capture API on for canary.
BUG=153388
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11260051
shadi@chromium.org
2012-10-26T01:54:03.180661Z
Revert 164239 - Add new media files for encrypted browser tests.
BUG=None
Review URL: https://codereview.chromium.org/11272048
TBR=shadi@chromium.org
Review URL: https://codereview.chromium.org/11274067
alexeypa@chromium.org
2012-10-26T02:07:27.818840Z
Fixing threading issues in remoting::DesktopProcess. The UI thread is now owned by the caller of remoting::DesktopThread so it can be properly shared between the caller and the class.
BUG=157808,157886
Review URL: https://codereview.chromium.org/11272036
hashimoto@chromium.org
2012-10-26T02:13:12.781915Z
chromeos: Add OWNERS to accessibility directory
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/11267036
zhaoqin@google.com
2012-10-26T02:14:57.614915Z
exclude more tests of browser_tests with Dr.Memory
TBR=bruening@chromium.org
Review URL: https://codereview.chromium.org/11275058
dalecurtis@google.com
2012-10-26T02:20:01.533388Z
Disable AudioDeviceListenerWinTest on XP.
BUG=none
TEST=compiles
TBR=scherkus
Review URL: https://codereview.chromium.org/11260054
jeremya@chromium.org
2012-10-26T02:25:50.555747Z
Add minimize/maximize buttons to app window; update style to win8.
BUG=146067
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11275026
dalecurtis@google.com
2012-10-26T02:25:53.377824Z
Disable AudioDeviceListenerWinTest on XP.
BUG=none
TEST=compiles
TBR=scherkus
Review URL: https://codereview.chromium.org/11260054
sail@chromium.org
2012-10-26T03:28:35.699722Z
Revert 164093 - Indicate tab recording state in tab strip
Adds MediaStreamCaptureIndicator::IsProcessCapturing() to retrieve recording state.
BUG=156130
Review URL: https://codereview.chromium.org/11236052
TBR=stevenjb@chromium.org
kinaba@chromium.org
2012-10-26T03:42:52.514227Z
Fix comments to reflect method renamings.
ReloadFeedFromServerIfNeeded => ReloadFromServerIfNeeded.
GData => Drive.
GetChangelist => GetDocuments.
BUG=none
Review URL: https://codereview.chromium.org/11260029
gbillock@chromium.org
2012-10-26T03:50:56.063462Z
Update mime type matching to handle parameters.
R=rvargas@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11193023
WebKit changeLogs from ]132486 to 132510]
commit-queue@webkit.org
2012-10-25T15:40:49.835512Z
Can't easily position the cursor on an empty line in a textarea with touch if touch adjustment is enabled
https://bugs.webkit.org/show_bug.cgi?id=97576
Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-25
Reviewed by Antonio Gomes.
Source/WebCore:
Consolidate touch adjustment candidates that are
editable. Adjustment becomes coarse being based
on the bounds of the outermost editable element.
This fix allows tap positioning of the text caret
on a blank line immediately above or below another
element.
Test: touchadjustment/editable-content.html
* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::hybridDistanceFunction):
LayoutTests:
Add test to verify that touch adjustment is coarse for
editable content, being based on the bounds of the
editable content and not its children.
* touchadjustment/editable-content-expected.txt: Added.
* touchadjustment/editable-content.html: Added.
kinuko@chromium.org
2012-10-25T15:55:22.292077Z
[chromium] External FileSystem should use the root path returned by requestFileSystem
https://bugs.webkit.org/show_bug.cgi?id=100372
Reviewed by Kentaro Hara.
External FileSystem should use the root path returned by
requestFileSystem as other type is doing. Current implementation
completely ignore the returned path.
New tests are to be added in chromium (as the type is only available in chromeos and chrome extensions)
* Modules/filesystem/chromium/DOMFileSystemChromium.cpp:
(WebCore::DOMFileSystemBase::createFileSystemURL):
kenneth@webkit.org
2012-10-25T15:58:21.813790Z
'resolution' MQ: Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100382
Reviewed by Antti Koivisto.
Special case print to not use the dpi of the screen, but one of 300.
Updated the resolution media query test to cover this.
Source/WebCore:
* css/MediaQueryEvaluator.cpp:
(WebCore::resolutionMediaFeatureEval): Update compared decimal points
to three, due to 300 / 96 being equal to 3.125.
LayoutTests:
* fast/media/mq-resolution-expected.txt:
* fast/media/mq-resolution.html:
dominik.rottsches@intel.com
2012-10-25T16:28:48.131940Z
Init timeout flag in ResourceErrorCF
https://bugs.webkit.org/show_bug.cgi?id=100349
Reviewed by Alexey Proskuryakov.
Initialize the timeout property to true if the network error was a timeout error.
This is a speculative fix for the XHR timeout test cases failing on Apple Win -
I can't verify this on a local machine.
No new tests, covered by
LayoutTests/http/tests/xmlhttprequest/timeout/*
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError): Init m_timeout from error code.
yurys@chromium.org
2012-10-25T16:30:35.286215Z
Web Inspector: inspector tests failing after r132454
https://bugs.webkit.org/show_bug.cgi?id=100381
Reviewed by Pavel Feldman.
Source/WebCore:
Added implementation for DOMNodeWrapperMap::reportMemoryUsage method,
otherwise no actual pointer is reported which breaks instrumentation.
* bindings/v8/IntrusiveDOMWrapperMap.h:
LayoutTests:
Enable memory instrumentation tests now that the problem is fixed.
* platform/chromium/TestExpectations:
chrome-bot@google.com
2012-10-25T17:20:28.714044Z
Allow LoaderStrategy to override the ResourceLoadScheduler
https://bugs.webkit.org/show_bug.cgi?id=100355
Reviewed by Anders Carlsson.
Source/WebCore:
Allow LoaderStrategy to override the implementation of the ResourceLoadScheduler.
Add a default implementation that just returns the current ResourceLoadScheduler.
No new tests (No behavior change).
Project file stuff:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
"Virtualize" ResourceLoadScheduler to expose build issues in preparation for future virtualization:
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::~ResourceLoadScheduler):
* loader/ResourceLoadScheduler.h:
(ResourceLoadScheduler):
Add the new method plus a default implementation:
* loader/LoaderStrategy.cpp:
(WebCore::LoaderStrategy::resourceLoadScheduler):
* loader/LoaderStrategy.h:
When strategies are enabled, use the LoaderStrategy for this:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
Source/WebKit2:
Add a WebKit2 subclass of ResourceLoadScheduler that currently adds no new functionality:
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::~WebResourceLoadScheduler):
* WebProcess/Network/WebResourceLoadScheduler.h:
WebProcess hangs on to the default shared WebResourceLoadScheduler:
* WebProcess/WebProcess.h:
(WebKit::WebProcess::webResourceLoadScheduler):
If the NetworkProcess is enabled, return the new WebResourceLoadScheduler:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::resourceLoadScheduler):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebKit2.xcodeproj/project.pbxproj:
commit-queue@webkit.org
2012-10-25T18:00:23.073638Z
Everything that sets RenderObject::m_style should go through setStyleInternal
https://bugs.webkit.org/show_bug.cgi?id=100338
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-25
Reviewed by Ojan Vafai.
Whenever we set m_style in RenderObject go through setStyleInternal and make
it inline. This gives a common place to put printfs and makes the code cleaner.
No new tests, just a refactor.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::setStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::setStyleInternal):
simon.fraser@apple.com
2012-10-25T18:08:21.424669Z
r132427 changed the tiling behavior of tiled layer TileCaches as well as the page tile cache
https://bugs.webkit.org/show_bug.cgi?id=100323
Reviewed by Anders Carlsson.
r132427 assumed that TileCaches were only used for the page, and changed the tile
size behavior of all non-page TileCaches.
Fix by giving TiledBacking a new 'CoverageForSlowScrolling' flag which
affects the tile size behavior.
Consolidated the two places that set TileCoverage into one, and in the process
reduced FrameView's direct communication with TiledBacking.
No new tests because we can't test tile size via tests.
* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen): Rely on RenderLayerCompositor to
call setIsInWindow() on the main page tile cache.
(WebCore::FrameView::willMoveOffscreen): Ditto.
(WebCore::FrameView::performPostLayoutTasks): Rather than explicitly tell
the TiledBacking that it should do stuff, just tell the compositor that
layout happened.
* platform/graphics/TiledBacking.h: New CoverageForSlowScrolling flag.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileSizeForCoverageRect): Only use one big tile
if the CoverageForSlowScrolling flag is set.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking): layer->isRootLayer()
is equivalent to renderer()->isRenderView() and clearer.
(WebCore::RenderLayerBacking::tiledBacking): Call adjustTileCacheCoverage().
It would be nice to move the rest of this TiledBacking code from here somehow.
(WebCore::RenderLayerBacking::adjustTileCacheCoverage): Update the TileCoverage
flags, taking into account horizontal and vertical scrollability independently,
and whether we're in slow scrolling mode.
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidLayout): Have the page
tiled backing update it's coverage flags.
(WebCore::RenderLayerCompositor::pageTiledBacking): Utility function.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Moved from FrameView.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
ojan@chromium.org
2012-10-25T18:16:28.533180Z
Get rid of ScriptController::clearForNavigation
https://bugs.webkit.org/show_bug.cgi?id=100390
Reviewed by Adam Barth.
Get rid of clearForNavigation and change resetIsolatedWorlds
to reset so that it can also do the hintForCollectGarbage call.
No new tests. No behavior change.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::reset):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
(ScriptController):
commit-queue@webkit.org
2012-10-25T18:49:51.592142Z
Touch adjustment snaps to wrong target at a plugin boundary.
https://bugs.webkit.org/show_bug.cgi?id=99938
Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-25
Reviewed by Antonio Gomes.
Source/WebCore:
Inidcate that an <embed> element can respond to
mouse click events, since mouse events are forwarded
to the plugin. Fixes touch adjustment at a plugin
boundary. Prior to the patch a clickable element
adjacent to the plugin would capture synthetic mouse
events from tap gestures that spanned the plugin
boundary.
Test: touchadjustment/plugin.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::willRespondToMouseClickEvents):
(WebCore):
* html/HTMLEmbedElement.h:
LayoutTests:
Test for touch adjustment at a plugin boundary.
Prior to the patch, plugins were not considered
candidates for touch adjustment.
* touchadjustment/plugin-expected.txt: Added.
* touchadjustment/plugin.html: Added.
No new ChangeLogs on V8